On Fri, Nov 26, 2021 at 05:34:36PM +0800, zhuyinbo wrote: > Hi Andrew, > > > I don't get udev log, but I can find that phy module wether be load by > lsmod ways, and you can try > > it in any a phy deice and in any arch platform. in addition, I will > send v2 version patch that need consider > > some phy device doesn't follow IEEE802.3 protocol strictly and doesn't > read phy id from phy register successfully, I'm not sure I understand what you've said above correctly. You seem to be saying that the module has been loaded (it appears in lsmod) but it doesn't get bound to the PHY device? If that is correct, there isn't a problem with the modalias, but there's something wrong in the driver matching. The last sentence seems to point at a completely different problem - one concerning an inability to correctly read the PHY ID from the PHY itself. If that's the case, then that isn't a problem with modalias, it's a problem with reading the PHY ID. The existing modalias scheme doesn't care about the format of the ID. Normally the least significant four bits are the PHY revision, but that doesn't always hold. Let's take a couple of examples: The PHY ID for a Marvell PHY is 0x01410dd1. This will expand to: mdio:00000001010000010000110111010001 The kernel modalias tables will be generated from an ID of 0x01410dd0 with a mask of 0xfffffff0. The mask means "ignore the bottom four bits". So, we end up with this in the module's alias table: mdio:0000000101000001000011011101???? udev knows that "?" is a wildcard. Consequently the above matches. On an Atheros PHY, this has an ID value of 0x004dd072. The driver also has a value of 0x004dd072 and a mask of 0xffffffef, meaning bit 4 is ignored: mdio:00000000010011011101000001110010 <= PHY ID mdio:000000000100110111010000011?0010 <= module alias table This will also match a PHY with id 0x004dd062. mdio:00000000010011011101000001100010 <= PHY ID The current modalias approach is flexible. Publishing the raw hex ID and having an exact match is too inflexible for phylib and will lead to users reporting regressions. Please show us: 1) the contents of the phy_id file for the PHY you are having problems with. This can be found in /sys/bus/mdio_bus/devices/.../phy_id 2) which driver in the kernel is a problem. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
