On Sun, Sep 5, 2021 at 3:45 AM Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote: > > On Sat, Sep 04, 2021 at 11:04:37AM -0700, Josh Poimboeuf wrote: > > On Tue, Aug 31, 2021 at 04:39:54PM +0900, Masahiro Yamada wrote: > > > objtool_dep includes include/config/{ORC_UNWINDER,STACK_VALIDATION} > > > so that all the objects are rebuilt when any of CONFIG_ORC_UNWINDER > > > and CONFIG_STACK_VALIDATION is toggled. > > > > > > As you can see in 'objtool_args', there are more CONFIG options > > > that affect the objtool command line. > > > > > > Adding more and more include/config/* is ugly and unmaintainable. > > > > > > Another issue is that non-standard objects are needlessly rebuilt. > > > Objects specified as OBJECT_FILES_NON_STANDARD is not processed by > > > objtool, but they are rebuilt anyway when CONFIG_ORC_UNWINDER or > > > CONFIG_STACK_VALIDATION is toggled. This is not a big deal, but > > > better to fix. > > > > > > A cleaner and more precise fix is to include the objtool command in > > > *.cmd files so any command change is naturally detected by if_change. > > > > Nice improvement, thanks! > > > > s/CONFIG_ORC_UNWINDER/CONFIG_UNWINDER_ORC/g > > > > And yes, this means the original ORC unwinder dependency didn't > > work: > > > > > -objtool_dep = $(objtool_obj) \ > > > - $(wildcard include/config/ORC_UNWINDER \ > > > - include/config/STACK_VALIDATION) > > With the typos fixed, and this dependency bug mentioned in the commit > log: Ah, nice catch. commit 11af847446ed0d131cf24d16a7ef3d5ea7a49554 missed to adjust the dependency part. I will update the commit log and mention this breakage. > Acked-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx> > > -- > Josh > -- Best Regards Masahiro Yamada