On Thu, Aug 12, 2021 at 7:54 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: > > Top-level Makefile targets 'versioncheck' and 'includecheck' don't > need a configured kernel (i.e., don't need a .config file), so add > them the the list of "no-dot-config-targets". > This eliminates the 'make' error: > > *** > *** Configuration file ".config" not found! > *** > *** Please run some configurator (e.g. "make oldconfig" or > *** "make menuconfig" or "make xconfig"). > *** > Makefile:759: include/config/auto.conf.cmd: No such file or directory > > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > Cc: Masahiro Yamada <masahiroy@xxxxxxxxxx> > Cc: Michal Marek <michal.lkml@xxxxxxxxxxx> > Cc: linux-kbuild@xxxxxxxxxxxxxxx > --- > Fixes: I couldn't determine this. > > Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > --- linux-next-20210811.orig/Makefile > +++ linux-next-20210811/Makefile > @@ -274,7 +274,8 @@ no-dot-config-targets := $(clean-targets > cscope gtags TAGS tags help% %docs check% coccicheck \ > $(version_h) headers headers_% archheaders archscripts \ > %asm-generic kernelversion %src-pkg dt_binding_check \ > - outputmakefile rustfmt rustfmtcheck > + outputmakefile rustfmt rustfmtcheck \ > + versioncheck includecheck > # Installation targets should not require compiler. Unfortunately, vdso_install > # is an exception where build artifacts may be updated. This must be fixed. > no-compiler-targets := $(no-dot-config-targets) install dtbs_install \ There is no good reason to invoke checkincludes.pl via GNU Make in the first place. A better solution is to do it by a shell script or to make checkincludes.pl traverse the subdirectories by itself. [1] An easy solution Add scripts/checkincludes-all: #!/bin/sh find . -name '*.[hcS]' -type f -print | sort \ | xargs $(dirname $0)/checkincludes.pl Then, remove the 'includecheck' target from the Makefile. You can do 'scripts/checkincludes-all' instead of 'make includecheck'. [2] A better solution Extend scripts/checkincludes.pl so that it checks all *.[hcS] files under the current directory when no argument is passed. You can simply do 'scripts/checkincludes.py' -- Best Regards Masahiro Yamada
