On Tue, Jun 22, 2021 at 10:05:40AM +0100, Mark Rutland wrote: > On Mon, Jun 21, 2021 at 04:18:22PM -0700, Nick Desaulniers wrote: > > We don't want compiler instrumentation to touch noinstr functions, which > > are annotated with the no_profile_instrument_function function > > attribute. Add a Kconfig test for this and make PGO and GCOV depend on > > it. > > > > If an architecture is using noinstr, it should denote that via this > > Kconfig value. That makes Kconfigs that depend on noinstr able to > > express dependencies in an architecturally agnostic way. > > > > Cc: Masahiro Yamada <masahiroy@xxxxxxxxxx> > > Cc: Peter Oberparleiter <oberpar@xxxxxxxxxxxxx> > > Link: https://lore.kernel.org/lkml/YMTn9yjuemKFLbws@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ > > Link: https://lore.kernel.org/lkml/YMcssV%2Fn5IBGv4f0@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ > > Suggested-by: Nathan Chancellor <nathan@xxxxxxxxxx> > > Suggested-by: Peter Zijlstra <peterz@xxxxxxxxxxxxx> > > Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > > FWIW, this looks good to me: > > Acked-by: Mark Rutland <mark.rutland@xxxxxxx> > > Catalin, Will, are you happy iwth the arm64 bit? Looks fine to me. Will
