On Wed, May 12, 2021 at 7:29 PM Segher Boessenkool
<segher@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, May 12, 2021 at 01:48:53PM +1000, Alexey Kardashevskiy wrote:
> > >Oh! I completely missed those few lines. Sorry for that :-(
> >
> > Well, I probably should have made it a separate patch anyway, I'll
> > repost separately.
>
> Thanks.
>
> > >To compensate a bit:
> > >
> > >>It still puzzles me why we need -C
> > >>(preserve comments in the preprocessor output) flag here.
> > >
> > >It is so that a human can look at the output and read it. Comments are
> > >very significant to human readers :-)
> >
> > I seriously doubt anyone ever read those :)
>
> I am pretty sure whoever wrote it did!
Keeping comments in the pre-processed linker scripts
is troublesome.
That is why -C was removed from scripts/Makefile.build
commit 5cb0512c02ecd7e6214e912e4c150f4219ac78e0
Author: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Thu Nov 2 14:10:37 2017 -0700
Kbuild: don't pass "-C" to preprocessor when processing linker scripts
You can entirely remove
CPPFLAGS_vdso32.lds += -P -C -Upowerpc
--
Best Regards
Masahiro Yamada
