Re: [PATCH] kbuild: replace LANG=C with LC_ALL=C

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 27, 2021 at 4:30 AM Matthieu Baerts
<matthieu.baerts@xxxxxxxxxxxx> wrote:
>
> Hi,
>
> Thank you for the patch!
>
> On 24/04/2021 13:48, Masahiro Yamada wrote:
> > LANG gives a weak default to each LC_* in case it is not explicitly
> > defined. LC_ALL, if set, overrides all other LC_* variables.
> >
> >   LANG  <  LC_CTYPE, LC_COLLATE, LC_MONETARY, LC_NUMERIC, ...  <  LC_ALL
> >
> > This is why documentation such as [1] suggests to set LC_ALL in build
> > scripts to get the deterministic result.
> >
> > LANG=C is not strong enough to override LC_* that may be set by end
> > users.
> >
> > [1]: https://reproducible-builds.org/docs/locales/
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> > ---
> >
> >  arch/powerpc/boot/wrapper                          | 2 +-
> >  scripts/nsdeps                                     | 2 +-
> >  scripts/recordmcount.pl                            | 2 +-
> >  scripts/setlocalversion                            | 2 +-
> >  scripts/tags.sh                                    | 2 +-
> >  tools/testing/selftests/net/mptcp/mptcp_connect.sh | 2 +-
>
> Acked-by: Matthieu Baerts <matthieu.baerts@xxxxxxxxxxxx> (mptcp)
>
> Cheers,
> Matt
> --
> Tessares | Belgium | Hybrid Access Solutions
> www.tessares.net


Applied to linux-kbuild.


-- 
Best Regards
Masahiro Yamada



[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux