On Thu, Apr 15, 2021 at 7:54 PM Boris Kolpackov <boris@xxxxxxxxxxxxxxxxx> wrote: > > Masahiro Yamada <masahiroy@xxxxxxxxxx> writes: > > > --- /dev/null > > +++ b/scripts/kconfig/internal.h > > @@ -0,0 +1,9 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > +#ifndef INTERNAL_H > > +#define INTERNAL_H > > + > > +struct menu; > > + > > +extern struct menu *current_menu, *current_entry; > > + > > +#endif /* INTERNAL_H */ > > Maybe call it menu.h instead of internal.h? Unless you have plans > to put other "internal" stuff in there. Yes, I will use this header for further cleanups of headers. > > > --- a/scripts/kconfig/parser.y > > +++ b/scripts/kconfig/parser.y > > @@ -28,7 +29,7 @@ static bool zconf_endtoken(const char *tokenname, > > > > struct symbol *symbol_hash[SYMBOL_HASHSIZE]; > > > > -static struct menu *current_menu, *current_entry; > > +struct menu *current_menu, *current_entry; > > Why not put these in menu.c? These variables are defined here before I started to maintain Kconfig. For now, I am just removing the 'static' directive. -- Best Regards Masahiro Yamada
