On Thu, Apr 15, 2021 at 1:47 AM Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote: > > I'm ok with this approach, but I'm curious: > If the user made a copy of the CLANG_FLAGS variable and modified its > copy, would TENTATIVE_CLANG_FLAGS even be necessary? IIUC, > TENTATIVE_CLANG_FLAGS is used to filter out certain flags before > passing them to bindgen? > > Or, I'm curious whether you even need to rename this variable (or > create a new variable) at all? Might make for a shorter diff if you > just keep the existing identifier (CLANG_FLAGS), but create them > unconditionally (at least not conditional on CC=clang). This is only for the GCC builds -- and yeah, it is a hack. I still need to think a bit more how to do this better; although ultimately the proper solution is to have `bindgen` use GCC like it does with `libclang` and avoid this altogether. That way we can ensure the bindings are correct, support plugins, etc. Cheers, Miguel
