On Thu, Mar 4, 2021 at 5:44 AM 'Nick Desaulniers' via Clang Built Linux <clang-built-linux@xxxxxxxxxxxxxxxx> wrote: > > On Wed, Mar 3, 2021 at 10:34 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > The test code in scripts/test_dwarf5_support.sh is somewhat difficult > > to understand, but after all, we want to check binutils >= 2.35.2 > > > > From the former discussion, the requrement for generating DRAWF v5 from > > ^typos: s/requrement/requirement, s/DRAWF/DWARF > > (in vim you can `:set spell` (`:set nospell` to disable), there's > probably a nice way to auto set this on buffer entry for a commit > message) I cannot be accustomed to vim. I use emacs for coding, and nano editor for editing simple text files, and input commit log. I invoke aspell from nano (Ctrl-t, Ctrl-s), but I sometimes forget to do spell checking. > > > > config DEBUG_INFO_DWARF5 > > bool "Generate DWARF Version 5 debuginfo" > > - depends on GCC_VERSION >= 50000 || CC_IS_CLANG > > - depends on CC_IS_GCC || $(success,$(srctree)/scripts/test_dwarf5_support.sh $(CC) $(CLANG_FLAGS)) > > + depends on GCC_VERSION >= 50000 || (CC_IS_CLANG && AS_IS_GNU && AS_VERSION >= 23502) || (CC_IS_CLANG && AS_IS_LLVM) > > Would this be more concise as: > + depends on GCC_VERSION >= 50000 || (CC_IS_CLANG && (AS_IS_LLVM > || (AS_IS_GNU && AS_VERSION >= 23502)) > Yes, this is simpler. I will do it in v2. Thanks. -- Best Regards Masahiro Yamada
