On verbose build, most shell scripts enable set -x making short version command output redundant. On silent build, no output is expected. Hence the short version should only be printed for quiet build. -- Bertrand
>From d7c757172de9b9d426c5f55381d2dce7c39b0c94 Mon Sep 17 00:00:00 2001 From: Bertrand Jacquin <bertrand@xxxxxxxxxxx> Date: Sat, 27 Feb 2021 03:12:11 +0000 Subject: [PATCH] build: print short version command only for quiet build On verbose build, most shell scripts enable set -x making short version command output redundant. On silent build, no output is expected. Hence the short version should only be printed for quiet build. --- kernel/gen_kheaders.sh | 2 +- scripts/adjust_autoksyms.sh | 2 +- scripts/link-vmlinux.sh | 2 +- scripts/mkcompile_h | 2 +- scripts/mkmakefile | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/gen_kheaders.sh b/kernel/gen_kheaders.sh index c1510f0ab3ea..8fdc74e3626e 100755 --- a/kernel/gen_kheaders.sh +++ b/kernel/gen_kheaders.sh @@ -56,7 +56,7 @@ if [ -f kernel/kheaders.md5 ] && exit fi -if [ "${quiet}" != "silent_" ]; then +if [ "${quiet}" = "quiet_" ]; then echo " GEN $tarfile" fi diff --git a/scripts/adjust_autoksyms.sh b/scripts/adjust_autoksyms.sh index 2b366d945ccb..b72d38200052 100755 --- a/scripts/adjust_autoksyms.sh +++ b/scripts/adjust_autoksyms.sh @@ -20,7 +20,7 @@ cur_ksyms_file="include/generated/autoksyms.h" new_ksyms_file="include/generated/autoksyms.h.tmpnew" info() { - if [ "$quiet" != "silent_" ]; then + if [ "$quiet" = "quiet_" ]; then printf " %-7s %s\n" "$1" "$2" fi } diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh index 3b261b0f74f0..5bb49fa08cdc 100755 --- a/scripts/link-vmlinux.sh +++ b/scripts/link-vmlinux.sh @@ -38,7 +38,7 @@ LDFLAGS_vmlinux="$3" # Will be supressed by "make -s" info() { - if [ "${quiet}" != "silent_" ]; then + if [ "${quiet}" = "quiet_" ]; then printf " %-7s %s\n" "${1}" "${2}" fi } diff --git a/scripts/mkcompile_h b/scripts/mkcompile_h index 4ae735039daf..8f453f7c12e1 100755 --- a/scripts/mkcompile_h +++ b/scripts/mkcompile_h @@ -9,7 +9,7 @@ PREEMPT_RT=$5 CC_VERSION="$6" LD=$7 -vecho() { [ "${quiet}" = "silent_" ] || echo "$@" ; } +vecho() { [ "${quiet}" = "quiet_" ] && echo "$@" ; } # Do not expand names set -f diff --git a/scripts/mkmakefile b/scripts/mkmakefile index 1cb174751429..cf71c588036d 100755 --- a/scripts/mkmakefile +++ b/scripts/mkmakefile @@ -7,7 +7,7 @@ # Usage # $1 - Kernel src directory -if [ "${quiet}" != "silent_" ]; then +if [ "${quiet}" = "quiet_" ]; then echo " GEN Makefile" fi