On Fri, Feb 26, 2021 at 6:20 AM Sami Tolvanen <samitolvanen@xxxxxxxxxx> wrote: > > Hi Masahiro, > > On Thu, Feb 25, 2021 at 12:07 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > On Fri, Feb 26, 2021 at 3:47 AM kernel test robot <lkp@xxxxxxxxx> wrote: > > > > > > Hi Masahiro, > > > > > > I love your patch! Perhaps something to improve: > > > > > > [auto build test WARNING on linus/master] > > > [also build test WARNING on next-20210225] > > > [cannot apply to kbuild/for-next asm-generic/master arm64/for-next/core m68k/for-next openrisc/for-next hp-parisc/for-next arc/for-next uclinux-h8/h8300-next nios2/for-linus v5.11] > > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > > And when submitting patch, we suggest to use '--base' as documented in > > > https://git-scm.com/docs/git-format-patch] > > > > > > url: https://github.com/0day-ci/linux/commits/Masahiro-Yamada/kbuild-build-speed-improvment-of-CONFIG_TRIM_UNUSED_KSYMS/20210226-000929 > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 29c395c77a9a514c5857c45ceae2665e9bd99ac7 > > > config: powerpc-mpc8313_rdb_defconfig (attached as .config) > > > compiler: powerpc-linux-gcc (GCC) 9.3.0 > > > reproduce (this is a W=1 build): > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > # https://github.com/0day-ci/linux/commit/014940331790a8cd9bee92c7201494ec3217201e > > > git remote add linux-review https://github.com/0day-ci/linux > > > git fetch --no-tags linux-review Masahiro-Yamada/kbuild-build-speed-improvment-of-CONFIG_TRIM_UNUSED_KSYMS/20210226-000929 > > > git checkout 014940331790a8cd9bee92c7201494ec3217201e > > > # save the attached .config to linux build tree > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc > > > > > > If you fix the issue, kindly add following tag as appropriate > > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > > > > > All warnings (new ones prefixed by >>): > > > > > > >> scripts/module.lds.S:7:5: warning: "CONFIG_TRIM_UNUSED_KSYMS" is not defined, evaluates to 0 [-Wundef] > > > > Thanks. This should be #ifdef, of course. > > I applied this series and changed these from #if to #ifdef, but I > still see the following build error with TRIM_UNUSED_KSYMS + > OF_UNITTEST: > > In file included from drivers/of/unittest-data/testcases.dtb.S:1: > ../include/asm-generic/vmlinux.lds.h:54:10: fatal error: > 'generated/keep-ksyms.h' file not found > #include <generated/keep-ksyms.h> > ^~~~~~~~~~~~~~~~~~~~~~~~ > 1 error generated. > > This is with x86_64_defconfig and scripts/config -e OF -e OF_UNITTEST > -e TRIM_UNUSED_KSYMS. > > Sami Thanks. I will fix it. I will come back with v2 probably after v5.12-rc1 is tagged. -- Best Regards Masahiro Yamada
