On Tue, Feb 16, 2021 at 3:15 AM Mickaël Salaün <mic@xxxxxxxxxxx> wrote: > > From: Mickaël Salaün <mic@xxxxxxxxxxxxxxxxxxx> > > Use the saved returned value of sym_get_string_value() instead of > calling it twice. > > Cc: Masahiro Yamada <masahiroy@xxxxxxxxxx> > Signed-off-by: Mickaël Salaün <mic@xxxxxxxxxxxxxxxxxxx> > Link: https://lore.kernel.org/r/20210215181511.2840674-2-mic@xxxxxxxxxxx > --- Applied to linux-kbuild. Thanks. > scripts/kconfig/conf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c > index db03e2f45de4..18a233d27a8d 100644 > --- a/scripts/kconfig/conf.c > +++ b/scripts/kconfig/conf.c > @@ -137,7 +137,7 @@ static int conf_string(struct menu *menu) > printf("%*s%s ", indent - 1, "", menu->prompt->text); > printf("(%s) ", sym->name); > def = sym_get_string_value(sym); > - if (sym_get_string_value(sym)) > + if (def) > printf("[%s] ", def); > if (!conf_askvalue(sym, def)) > return 0; > -- > 2.30.0 > -- Best Regards Masahiro Yamada
