On Wed, Feb 17, 2021 at 6:33 AM Nathan Chancellor <nathan@xxxxxxxxxx> wrote: > > When using AMD's Optimizing C/C++ Compiler (AOCC), the build fails due > to a # character in the version string, which is interpreted as a > comment: > > $ make CC=clang defconfig init/main.o > include/config/auto.conf.cmd:1374: *** invalid syntax in conditional. Stop. > > $ sed -n 1374p include/config/auto.conf.cmd > ifneq "$(CC_VERSION_TEXT)" "AMD clang version 11.0.0 (CLANG: AOCC_2.3.0-Build#85 2020_11_10) (based on LLVM Mirror.Version.11.0.0)" > > Remove all # characters in the version string so that the build does not > fail unexpectedly. > > Link: https://github.com/ClangBuiltLinux/linux/issues/1298 > Reported-by: Michael Fuckner <michael@xxxxxxxxxxx> > Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx> > --- After some thoughts, I decided to apply this as-is for now. Ideally, the part "AOCC_2.3.0-Build#85" could be escaped like "AOCC_2.3.0-Build\#85" so that the original version string is preserved. I know it is impossible because escape sequence handling in Kconfig is buggy. So, I accept dropping problematic '#' characters entirely, and I agree this is the safest fix. When I have time, I might want to revisit this with a Kconfig fix. Applied to linux-kbuild. Thanks. -- Best Regards Masahiro Yamada
