On Thu, Feb 11, 2021 at 10:48 PM Stephen Zhang <stephenzhangzsd@xxxxxxxxx> wrote: > > Nathan Chancellor <nathan@xxxxxxxxxx> 于2021年2月11日周四 上午2:24写道： > > > > On Wed, Feb 10, 2021 at 08:15:27PM +0800, Stephen Zhang wrote: > > > Nathan Chancellor <nathan@xxxxxxxxxx> 于2021年2月10日周三 上午3:27写道： > > > > > > > Just as an FYI, your email was HTML, which means it won't hit LKML. > > > > > > > > > Thanks for pointing that out. The existence of a GFW makes it difficult for > > > me to connect > > > to the mail server. so I use git client to send patches only and reply to > > > emails with > > > gmail web client. > > > > You can configure your Gmail web client to send text responses by > > default by clicking on the three dot menu in the compose window then > > chose the "plain text mode" option. > > > > Thanks, this has always been a problem for me. > > > The build directory needs to be involved because that is where the .cmd > > files will be but the source directory needs to be known because the > > source files in the .cmd files are relative to the source directory, not > > the build directory. This happens to work in most situations like I > > point out above but not always. > > > > I think that my patch is most likely the way to go unless others feel > > differently. It would be nice if you could give it a go. > > > > Cheers, > > Nathan > > Do you mean my patch's failure in some cases is because the build > directoty isn't involved after using "-d" to specify the source directory? > > Actually, the build directory has already been involved by the "path" > argument. See: > > def main(): > for path in paths: > .... > if os.path.isdir(path): > cmdfiles = cmdfiles_in_dir(path) > ..... > > where the value of paths is passed by the "path" argument. Do I miss > something? > > Cheers, > Stephen > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@xxxxxxxxxxxxxxxx. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/CALuz2%3DeSv2N2Qp7GimLgdWjvWDwDh1Dj0Q7Czm4Br5a50rs4ew%40mail.gmail.com. Please stop. Commit 6ca4c6d25949117dc5b4845612e290b6d89e70a8 removed the tools/ support. There exist two build systems in the Linux source tree. Kbuild covers the entire tree except tools/. The tools/ directory adopts a different build system. It is a pity that the tools/ directory went in a wrong direction, and people try to fix problems in a wrong layer. You are not the first person to send to tweak obj/source trees of this script. You can not do this correctly without terribly messing up the code. Please do not try to support tools/. -- Best Regards Masahiro Yamada
