On Wed, Feb 3, 2021 at 4:30 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > On Thu, Feb 4, 2021 at 8:16 AM Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote: > > > > On Wed, Feb 3, 2021 at 2:24 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > > > On Sat, Jan 30, 2021 at 10:52 AM Nathan Chancellor <nathan@xxxxxxxxxx> wrote: > > > > > > > > On Fri, Jan 29, 2021 at 04:44:00PM -0800, Nick Desaulniers wrote: > > > > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice which is > > > > > the default. Does so in a way that's forward compatible with existing > > > > > configs, and makes adding future versions more straightforward. > > > > > > > > > > GCC since ~4.8 has defaulted to this DWARF version implicitly. > > > > > > > > > > Suggested-by: Arvind Sankar <nivedita@xxxxxxxxxxxx> > > > > > Suggested-by: Fangrui Song <maskray@xxxxxxxxxx> > > > > > Suggested-by: Nathan Chancellor <nathan@xxxxxxxxxx> > > > > > Suggested-by: Masahiro Yamada <masahiroy@xxxxxxxxxx> > > > > > Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > > > > > > > > One comment below: > > > > > > > > Reviewed-by: Nathan Chancellor <nathan@xxxxxxxxxx> > > > > > > > > > --- > > > > > Makefile | 5 ++--- > > > > > lib/Kconfig.debug | 16 +++++++++++----- > > > > > 2 files changed, 13 insertions(+), 8 deletions(-) > > > > > > > > > > diff --git a/Makefile b/Makefile > > > > > index 95ab9856f357..d2b4980807e0 100644 > > > > > --- a/Makefile > > > > > +++ b/Makefile > > > > > @@ -830,9 +830,8 @@ ifneq ($(LLVM_IAS),1) > > > > > KBUILD_AFLAGS += -Wa,-gdwarf-2 > > > > > > > > It is probably worth a comment somewhere that assembly files will still > > > > have DWARF v2. > > > > > > I agree. > > > Please noting the reason will be helpful. > > > > Via a comment in the source, or in the commit message? > > > > > > > > Could you summarize Jakub's comment in short? > > > https://patchwork.kernel.org/project/linux-kbuild/patch/20201022012106.1875129-1-ndesaulniers@xxxxxxxxxx/#23727667 > > > > Via a comment in the source, or in the commit message? > > > Both in the source if you can summarize it in three lines or so. > > > If you need to add more detailed explanation, > please provide it in the commit log. This information is mostly in the commit log of patch 2. I will reword it with additional info from the link you sent, but I find that such minutiae is resulting in diminishing returns on subsequent respins of the patch series. I implore you to reword v8 (which I will send) as you see fit when applying the series. -- Thanks, ~Nick Desaulniers
