On Wed, Feb 03, 2021 at 11:34:50AM +0100, Daniel Vetter wrote: > On Thu, Jan 28, 2021 at 07:14:10PM +0100, Christoph Hellwig wrote: > > drm_fb_helper_modinit has a lot of boilerplate for what is not very > > simple functionality. Just open code it in the only caller using > > IS_ENABLED and IS_MODULE, and skip the find_module check as a > > request_module is harmless if the module is already loaded (and not > > other caller has this find_module check either). > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > Hm I thought I've acked this one already somewhere for merging through > your tree. > > Acked-by: Daniel Vetter <daniel.vetter@xxxxxxxx> The difference is that this new version loses the find_module entirely, while the previous one replaced it with the module_loaded helper that didn't make it to the second version of the series.
