On Thu, Jan 28, 2021 at 12:08 PM Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
>
> Add a check for compiler mismatch, but only check the major version.
I think this is wrong for multiple reasons.
The most fundamental reason is that it's pointless and doesn't
actually do what you claim it does.
Just doing a "make oldconfig" will reset the CONFIG_xyz_VERSION to
whatever is installed, and now your check doesn't actually do
anything, since you're not actually checking what the kernel was
compiled with!
So I think that check is pointless and entirely misleading. It doesn't
do what you want it to do, and what you claim it does.
I'm not convinced about the whole magic vs minor argument either. The
whole "new compiler features" thing is a red herring - even if you do
have new compiler features, that in itself has very little to do with
whether the resulting object files are compatible or not.
So I say NAK, on the basis that the patch is nonsensical, tests the
wrong thing, and doesn't really have a technical reason for it.
Linus
