On Thu, Jan 28, 2021 at 05:22:40PM +0100, Christoph Hellwig wrote: > > We need to either update the function description or keep this check. > > > > I prefer to keep the check. The function does the right thing also > > for the object "vmlinux". Also the livepatch code includes many > > similar paranoid checks that makes the code less error prone > > against any further changes. > > Well, the check is in the caller now where we have a conditional for > it. So I'd be tempted to either update the comment, or just drop the > patch. Also even without the check I think it will do the right thing when called for vmlinux given that it simplify won't find a module called vmlinux..
