On Sat, Jan 23, 2021 at 4:27 AM Elliot Berman <eberman@xxxxxxxxxxxxxx> wrote: > > Reduce repeated logic around expanding composite objects in preparation > for later commit to support nested composite objects. > > Signed-off-by: Elliot Berman <eberman@xxxxxxxxxxxxxx> This patch is a nice clean-up regardless of your main motivation in 2/2. I removed the "in preparation ..." part. Applied to linux-kbuild. Thanks. > --- > scripts/Makefile.lib | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > index 213677a5..93e4f10 100644 > --- a/scripts/Makefile.lib > +++ b/scripts/Makefile.lib > @@ -56,15 +56,19 @@ else > obj-y := $(filter-out %/, $(obj-y)) > endif > > +# Expand $(foo-objs) $(foo-y) by calling $(call suffix-search,foo.o,-objs -y) > +suffix-search = $(foreach s,$(2),$($(1:.o=$s))) > # If $(foo-objs), $(foo-y), $(foo-m), or $(foo-) exists, foo.o is a composite object > -multi-used-y := $(sort $(foreach m,$(obj-y), $(if $(strip $($(m:.o=-objs)) $($(m:.o=-y)) $($(m:.o=-))), $(m)))) > -multi-used-m := $(sort $(foreach m,$(obj-m), $(if $(strip $($(m:.o=-objs)) $($(m:.o=-y)) $($(m:.o=-m)) $($(m:.o=-))), $(m)))) > +multi-search = $(sort $(foreach m,$(1), $(if $(strip $(call suffix-search,$(m),$(2) -)), $(m)))) > +multi-used-y := $(call multi-search,$(obj-y),-objs -y) > +multi-used-m := $(call multi-search,$(obj-m),-objs -y -m) > multi-used := $(multi-used-y) $(multi-used-m) > > # Replace multi-part objects by their individual parts, > # including built-in.a from subdirectories > -real-obj-y := $(foreach m, $(obj-y), $(if $(strip $($(m:.o=-objs)) $($(m:.o=-y)) $($(m:.o=-))),$($(m:.o=-objs)) $($(m:.o=-y)),$(m))) > -real-obj-m := $(foreach m, $(obj-m), $(if $(strip $($(m:.o=-objs)) $($(m:.o=-y)) $($(m:.o=-m)) $($(m:.o=-))),$($(m:.o=-objs)) $($(m:.o=-y)) $($(m:.o=-m)),$(m))) > +real-search = $(foreach m,$(1), $(if $(strip $(call suffix-search,$(m),$(2) -)),$(call suffix-search,$(m),$(2)),$(m))) > +real-obj-y := $(call real-search, $(obj-y),-objs -y) > +real-obj-m := $(call real-search, $(obj-m),-objs -y -m) > > always-y += $(always-m) > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- Best Regards Masahiro Yamada
