On Sat, Jan 23, 2021 at 10:17:59PM +0900, Masahiro Yamada wrote:
> On Sat, Jan 23, 2021 at 3:19 AM Robert Karszniewicz
> <r.karszniewicz@xxxxxxxxx> wrote:
> >
> > gcc-plugin.sh has been removed in commit
> > 1e860048c53e ("gcc-plugins: simplify GCC plugin-dev capability test").
> >
> > Signed-off-by: Robert Karszniewicz <r.karszniewicz@xxxxxxxxx>
> > ---
> > Documentation/kbuild/gcc-plugins.rst | 6 ------
> > scripts/dummy-tools/gcc | 15 ---------------
> > 2 files changed, 21 deletions(-)
> >
> > [...]
> > diff --git a/scripts/dummy-tools/gcc b/scripts/dummy-tools/gcc
> > index 33487e99d83e..a484de576e6f 100755
> > --- a/scripts/dummy-tools/gcc
> > +++ b/scripts/dummy-tools/gcc
> > @@ -74,18 +74,3 @@ if arg_contain -S "$@"; then
> > exit 0
> > fi
> > fi
> > -
> > -# For scripts/gcc-plugin.sh
> > -if arg_contain -print-file-name=plugin "$@"; then
> > - plugin_dir=$(mktemp -d)
> > -
> > - sed -n 's/.*#include "\(.*\)"/\1/p' $(dirname $0)/../gcc-plugins/gcc-common.h |
> > - while read header
> > - do
> > - mkdir -p $plugin_dir/include/$(dirname $header)
> > - touch $plugin_dir/include/$header
> > - done
> > -
> > - echo $plugin_dir
> > - exit 0
> > -fi
>
>
> Well, it is wrong to remove this hunk entirely.
> It would break the ability to enable GCC_PLUGINS.
>
> I will simplify this part.
> https://lore.kernel.org/patchwork/patch/1369968/
>
>
> I took the only change to Documentation/kbuild/gcc-plugins.rst
> from your patch but this document contains more stale info.
>
> https://lore.kernel.org/patchwork/patch/1370008/
I see, thanks for letting me know,
Robert
