On Mon, Dec 14, 2020 at 5:21 PM John Millikin <jmillikin@xxxxxxxxx> wrote:
>
> BSD awk is fussy about the order of '-v' and '-f' flags, and it requires
> a space after the flag name. GNU awk is fine with both forms, so the
> definition of 'cmd_unroll' can be trivially tweaked to let the lib/raid6
> Makefile work with either awk.
Does it depend on the awk version?
I tried this in FreeBSD 12.
masahiro@:~ $ cat test.awk
BEGIN { print N }
masahiro@:~ $ awk --version
awk version 20121220 (FreeBSD)
masahiro@:~ $ awk -ftest.awk -vN=1
1
It worked for me.
> Signed-off-by: John Millikin <john@xxxxxxxxxxxxxxxxx>
> ---
> lib/raid6/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/raid6/Makefile b/lib/raid6/Makefile
> index b4c0df6d706d..c770570bfe4f 100644
> --- a/lib/raid6/Makefile
> +++ b/lib/raid6/Makefile
> @@ -48,7 +48,7 @@ endif
> endif
>
> quiet_cmd_unroll = UNROLL $@
> - cmd_unroll = $(AWK) -f$(srctree)/$(src)/unroll.awk -vN=$* < $< > $@
> + cmd_unroll = $(AWK) -v N=$* -f $(srctree)/$(src)/unroll.awk < $< > $@
>
> targets += int1.c int2.c int4.c int8.c int16.c int32.c
> $(obj)/int%.c: $(src)/int.uc $(src)/unroll.awk FORCE
> --
> 2.24.3 (Apple Git-128)
--
Best Regards
Masahiro Yamada
