Hi All, Thanks Jessica for the feedback! I have updated the commit message to include the justification and common use cases for the patch series. I have also added the config MODULE_SCMVERSION so that this is not enabled by default. Please take a look and let me know of any concerns or issues found. Thanks, Will Will McVicker (2): scripts/setlocalversion: allow running in a subdir modules: introduce the MODULE_SCMVERSION config Documentation/ABI/stable/sysfs-module | 18 ++++++++++++++++++ include/linux/module.h | 1 + init/Kconfig | 12 ++++++++++++ kernel/module.c | 2 ++ scripts/Makefile.modpost | 22 ++++++++++++++++++++++ scripts/mod/modpost.c | 24 +++++++++++++++++++++++- scripts/setlocalversion | 5 ++--- 7 files changed, 80 insertions(+), 4 deletions(-) -- 2.29.2.576.ga3fc446d84-goog