On Wed, Nov 25, 2020 at 01:05:39AM +0000, Will McVicker wrote: > Hi All, > > I have updated the patchset to: > > *) Include Documentation. > *) Use a consistent output pattern for the SCM version. > > In my debugging, I found that the vermagic reported by modinfo can actually > vary based on how the module was loaded. For example, if you have a module in > the initramfs that is newer than the module on disk, then the initramfs module > will be loaded (not the one on disk) during boot. Then, when you run the > command: > > $ modinfo MODULENAME > > The vermagic returned will actually be the vermagic of the module on disk and > not the one in the initramfs which was actually loaded. With that being said, > adding this scmversion attribute ensures that you can *always* get the correct > SCM version of the module that loaded. > > Please take a look at the updated patch and provide any comments you find. > > Thanks, > Will > > Will McVicker (2): > scripts/setlocalversion: allow running in a subdir > modules: add scmversion field > > Documentation/ABI/stable/sysfs-module | 17 +++++++++++++++++ > include/linux/module.h | 1 + > kernel/module.c | 2 ++ > scripts/Makefile.modpost | 20 ++++++++++++++++++++ > scripts/mod/modpost.c | 24 +++++++++++++++++++++++- > scripts/setlocalversion | 5 ++--- > 6 files changed, 65 insertions(+), 4 deletions(-) > > -- > 2.29.2.454.gaff20da3a2-goog > Hi Jessica, Masahiro, and Michal, Friendly reminder :) Thanks, Will
