Re: kconfig: diagnostics cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Masahiro Yamada <masahiroy@xxxxxxxxxx> writes:

> We can change them if there is a reason, but I cannot see it in your
> description.

> Boris Kolpackov <boris@xxxxxxxxxxxxxxxxx> wrote:
>
> > 1. Add 'warning' word to $(warning-if) output:

This will make the diagnostics consistent with other places in kconfig
where warnings are issued (see conf_warrning() in confdata.c).


> > 2. Print $(info) output to stderr instead of stdout.

There are two reasons:

1. Error, warning, and info are different diagnostics levels. It was
   surprising to me that the first two go to stderr while info goes
   to stdout. For example, as a user, if I redirect stderr, I would
   naturally expect all the diagnostics to go there.

2. More importantly, stdout is used by terminal-based UI configurators.
   So depending on exactly when $(info) is issued, its output could either
   be clobbered by UI (so the user won't notice it) or it can clobber UI
   (so the user will see broken UI).



[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux