On Sat, Nov 21, 2020 at 01:16:51AM +0000, Will McVicker wrote: > +/** > + * struct modinfo_attrs - Module attributes. > + * @module_uevent: Used to notify udev of events. > + * @modinfo_version: Module version. > + * @modinfo_srcversion: Checksum of module source. > + * @modinfo_scmversion: SCM version of module source. > + * @modinfo_initstate: Module init state. > + * @modinfo_coresize: Module core layout size. > + * @modinfo_initsize: Module init layout size. > + * @modinfo_taint: Indicates if the module is tainted. > + * @modinfo_refcnt: Number of references in the kernel to the module. > + * > + * These are the module attributes accessible via the sysfs files > + * /sys/module/<module_name>/<attribute>. > + * > + * The following subset of attributes can also be accessed via the modinfo tool > + * as well: version, srcversion, and scmversion. > + */ > static struct module_attribute *modinfo_attrs[] = { > &module_uevent, > &modinfo_version, > &modinfo_srcversion, > + &modinfo_scmversion, > &modinfo_initstate, > &modinfo_coresize, > &modinfo_initsize, This isn't the normal way to document an array, with kerneldoc, I don't think I've seen that anywhere else in the kernel, have you? Anyway, again, Documentation/ABI/ is the correct place for this. thanks, greg k-h