On Mon, Nov 2, 2020 at 11:32 PM Boris Kolpackov <boris@xxxxxxxxxxxxxxxxx> wrote: > > Masahiro Yamada <masahiroy@xxxxxxxxxx> writes: > > > On Fri, Oct 30, 2020 at 12:52 AM Boris Kolpackov > > <boris@xxxxxxxxxxxxxxxxx> wrote: > > > > > > - Add missing includes. > > > - Remove no longer necessary includes. > > > - Separate non-portable header includes for easier porting. > > > > I think the definition of "non-portable" > > depends on how far we expand the supported system. > > > > I guess you want to segregate <unistd.h> and <sys/mmap.h> > > because you do not have them on Windows, correct? > > Correct. I have a set of patches that make kconfig portable to > Windows. I assume there is no interest in these patches here so > I will be maintaining them out of tree (but let me know if my > assumption is wrong and I will happily submit them). Splitting > the header inclusions into two blocks make these patches a bit > cleaner and more resilient to changes. > > Let me know if you would like me to change the patch to (1) > clarify the non-portable part or (2) get rid of the split. If you send v2 with the first two items: - Add missing includes. - Remove no longer necessary includes. I will accept it. I am not interested in the last one because running kconfig on Windows is not officially supported. -- Best Regards Masahiro Yamada
