On Wed, Oct 14, 2020 at 01:48:28AM +0900, Masahiro Yamada wrote: > On Sat, Sep 26, 2020 at 5:45 PM Josh Triplett <josh@xxxxxxxxxxxxxxxx> wrote: > > > > On Sat, Sep 26, 2020 at 02:45:38PM +0900, Masahiro Yamada wrote: > > > On Sat, Sep 26, 2020 at 7:29 AM Josh Triplett <josh@xxxxxxxxxxxxxxxx> wrote: > > > > > > > > With CONFIG_MODULES disabled, "make bindeb-pkg" fails in > > > > scripts/package/builddeb with: > > > > > > > > find: ‘Module.symvers’: No such file or directory > > > > > > > > The deploy_kernel_headers function in scripts/package/builddeb calls: > > > > > > > > find arch/$SRCARCH/include Module.symvers include scripts -type f > > > > > > > > But find errors out if any of its command-line arguments doesn't exist. > > > > > > > > This could be fixed by checking whether that file exists first, but if > > > > CONFIG_MODULES is disabled, it doesn't really make sense to build the > > > > linux-headers package at all. Perhaps that whole package could be > > > > disabled when modules are disabled? > > > > > > I agree. > > > > > > > > > How about something like the following? > > > > That looks good to me. > > > > (It would be nice, as well, to have some conditional wrapped around the > > linux-libc-dev package. I had a patch for that a while ago at > > https://lore.kernel.org/lkml/b45738b05bb396e175a36f67b02fa01de4c7472f.1583912084.git.josh@xxxxxxxxxxxxxxxx/ > > , but that's probably not the ideal way to do it. I'd love to see a way > > to disable that extra deb, though, as it adds time to the deb build > > process for a package that most people looking to build a deb won't > > need or install.) > > I am skeptical about this approach. > > > I think the ideal way would be > to support individual binary package build in dpkg-buildpackage. > > I do not know if it has been already achieved, or > it is a planned feature. Given the way Debian packages are built, that's not really an option. There are targets in debian/rules to build arch-specific and arch-independent packages, but not targets to build individual binary packages. Are you more concerned about avoiding the code conditionally generating the control file, or about avoiding the code that has to pass the controlling environment variable down through build steps?
