There is a movement to make the code base compile clean with W=1. Some
subsystems are already clean. In order to keep them clean, we need
developers to build new code with W=1 by default in these
subsystems. Otherwise new warnings will be added. To prove the point:
commit e666a4c668528ae1f5b8b3a2e7cb6a5be488dfbb
Merge: d0186842ec5f d0ea5cbdc286
Author: David S. Miller <davem@xxxxxxxxxxxxx>
Date: Fri Sep 25 16:29:00 2020 -0700
Merge branch 'drivers-net-warning-clean'
Jesse Brandeburg says:
====================
make drivers/net/ethernet W=1 clean
Then 4 days later a new W=1 warning has added:
drivers/net/ethernet//chelsio/inline_crypto/ch_ktls/chcr_ktls.c: In function ‘chcr_ktls_cpl_set_tcb_rpl’:
drivers/net/ethernet//chelsio/inline_crypto/ch_ktls/chcr_ktls.c:684:22: warning: implicit conversion from ‘enum <anonymous>’ to ‘enum ch_ktls_open_state’ [-Wenum-conversion]
684 | tx_info->open_state = false;
This patchset refactors the core Makefile warning code to allow the
additional warnings W=1 adds available to any Makefile. The Ethernet
driver subsystem Makefiles then make use of this to make W=1 the
default for this subsystem.
v2:
Address the comment that we need to be able to add new W=1 compiler
flags without actually causing new warnings for builds which don't have W=1
Andrew Lunn (2):
Makefile.extrawarn: Add symbol for W=1 warnings for today
driver/net/ethernet: Sign up for W=1 as defined on 20200930
drivers/net/ethernet/Makefile | 3 +++
scripts/Makefile.extrawarn | 34 ++++++++++++++++++----------------
2 files changed, 21 insertions(+), 16 deletions(-)
--
2.28.0
