> On Sep 30, 2020, at 3:02 PM, Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx> wrote: > > On Wed, Sep 30, 2020 at 04:15:07PM -0400, Eric Snowberg wrote: >> Move functionality within load_system_certificate_list to a common >> function, so it can be reused in the future. >> >> Signed-off-by: Eric Snowberg <eric.snowberg@xxxxxxxxxx> > > I rather think now rather than the future. I think this should be part > of a patch set where the re-use actually happens. load_certificate_list is being used in the second patch in the series [1]. It uses the now common code, to load the revocation certificates, just like the system certificates are being loaded in this patch. > Without that context, I rather not say anything about this patch. > Neither an issue for me if it gets applied. This is just a guideline > that I follow (in order to manage this chaos). > > Looking at the code change, I do not see anything strikingly wrong in > it. Thanks [1] https://lore.kernel.org/patchwork/patch/1315486/
