On Thu, Aug 13, 2020 at 9:50 AM Nathan Chancellor <natechancellor@xxxxxxxxx> wrote: > > On Wed, Aug 12, 2020 at 03:52:54PM -0700, 'Nick Desaulniers' via Clang Built Linux wrote: > > On Wed, Aug 12, 2020 at 12:56 PM Nathan Huckleberry <nhuck@xxxxxxxxxx> wrote: > > > > > > On Wed, Aug 12, 2020 at 12:40 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > > > > > > > > > I improved gen_compile_commands.py in the first two patches, > > > > then rebased Nathan's v7 [1] on top of them. > > > > To save time, I modified the Makefile part. > > > > No change for run-clang-tools.py > > > > > > > > I am not sure if the new directory, scripts/clang-tools/, > > > > is worth creating only for 2 files, but I do not have > > > > a strong opinion about it. > > > > > > > > "make clang-tidy" should work in-tree build, > > > > out-of-tree build (O=), and external module build (M=). > > > > Tests and reviews are appreciated. > > > > > > > > "make clang-tidy" worked for me. > > > > > > > > masahiro@oscar:~/workspace/linux-kbuild$ make -j24 CC=clang clang-tidy > > > > DESCEND objtool > > > > CALL scripts/atomic/check-atomics.sh > > > > CALL scripts/checksyscalls.sh > > > > CHK include/generated/compile.h > > > > GEN compile_commands.json > > > > CHECK compile_commands.json > > > > > > > > But "make clang-analyzer" just sprinkled the following error: > > > > > > > > Error: no checks enabled. > > > > USAGE: clang-tidy [options] <source0> [... <sourceN>] > > > > I wasn't able to reproduce Masahiro's reported failure, but seeing as > > he has `GEN` for compile_commands.json and I have `CHK`, I wonder if > > that's from a run when the series was still under development? > > > > I can reproduce if I run: > > $ clang-tidy '-checks=' > > so maybe was string quoting problem? > > > > > > > > > > I built clang-tidy from the latest source. > > > > I had no idea how to make it work... > > > > > > How are you building clang-tidy? The clang static-analyzer may not > > > have been built. > > > I believe the static analyzer is built as a part of clang, not as a > > > part of clang-tools-extra. > > > > > > I use this command to build. > > > cmake -DCMAKE_BUILD_TYPE="release" > > > -DLLVM_TARGETS_TO_BUILD="X86;AArch64;ARM;RISCV" > > > -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra;lld;llvm-as" > > > -DLLVM_ENABLE_LLD=1 -G "Ninja" ../llvm > > > > > > Adding clang to the list of -DLLVM_ENABLE_PROJECTS will build the > > > static analyzer. > > > -DCLANG_ENABLE_STATIC_ANALYZER=1 might also work, but I haven't tested it. > > > > > > I tested the patchset and both clang-tidy and clang-analyzer work for me. > > > > If you rename clang-tidy in your build dir, and ensure you don't have > > a `clang-tidy` in your $PATH (`which clang-tidy`), maybe there's more > > we can do to politely inform the user they're missing a dependency to > > execute the make target? Not sure if we could could test that > > clang-tidy supports the clang-analyzer-* checks. Isn't there an > > invocation that prints the supported checks? `clang-tidy '-checks=*' > > --list-checks` is in my shell history. Maybe grepping that and > > informing the user how to fix the problem might solve a "papercut?" > > > > If I remove clang-tidy with this series applied, I get (the failure is > > obvious to me, but...): > > ``` > > $ make LLVM=1 -j71 clang-tidy > > ... > > multiprocessing.pool.RemoteTraceback: > > """ > > Traceback (most recent call last): > > File "/usr/lib/python3.8/multiprocessing/pool.py", line 125, in worker > > result = (True, func(*args, **kwds)) > > File "/usr/lib/python3.8/multiprocessing/pool.py", line 48, in mapstar > > return list(map(*args)) > > File "./scripts/clang-tools/run-clang-tools.py", line 54, in run_analysis > > p = subprocess.run(["clang-tidy", "-p", args.path, checks, entry["file"]], > > File "/usr/lib/python3.8/subprocess.py", line 489, in run > > with Popen(*popenargs, **kwargs) as process: > > File "/usr/lib/python3.8/subprocess.py", line 854, in __init__ > > self._execute_child(args, executable, preexec_fn, close_fds, > > File "/usr/lib/python3.8/subprocess.py", line 1702, in _execute_child > > raise child_exception_type(errno_num, err_msg, err_filename) > > FileNotFoundError: [Errno 2] No such file or directory: 'clang-tidy' > > """ > > > > The above exception was the direct cause of the following exception: > > > > Traceback (most recent call last): > > File "./scripts/clang-tools/run-clang-tools.py", line 74, in <module> > > main() > > File "./scripts/clang-tools/run-clang-tools.py", line 70, in main > > pool.map(run_analysis, datastore) > > File "/usr/lib/python3.8/multiprocessing/pool.py", line 364, in map > > return self._map_async(func, iterable, mapstar, chunksize).get() > > File "/usr/lib/python3.8/multiprocessing/pool.py", line 771, in get > > raise self._value > > FileNotFoundError: [Errno 2] No such file or directory: 'clang-tidy' > > make: *** [Makefile:1861: clang-tidy] Error 1 > > ``` > > $ clang-tidy '-checks=*' --list-checks | grep clang-analyzer | wc -l > > 111 > > > > And I'm not sure you can even build clang or clang-tidy but not the analyzer. > > I think that is the point of '-DCLANG_ENABLE_STATIC_ANALYZER=OFF'. > clang-tools-extra/clang-tidy/CMakeLists.txt has some checks for > CLANG_ENABLE_STATIC_ANALYZER to link in certain libraries related to > the analyzer. > > For the record, tc-build adds that cmake define: > > https://github.com/ClangBuiltLinux/tc-build/blob/071eeefd2e201d3f24468cc06ed6a5860161437d/build-llvm.py#L610-L613 > > $ ../build-llvm.py --build-stage1-only --projects "clang;clang-tools-extra" --targets X86 > ... > > $ ../build/llvm/stage1/bin/clang-tidy '-checks=*' --list-checks | grep clang-analyzer | wc -l > 0 > > If I remove that define and rebuild: > > $ ../build-llvm.py --build-stage1-only --projects "clang;clang-tools-extra" --targets X86 > ... > > $ ../build/llvm/stage1/bin/clang-tidy '-checks=*' --list-checks | grep clang-analyzer | wc -l > 111 > > I suppose if this series depends on it, we can remove that from the base > defines and either add a flag to enable/disable it depending on people's > preferences. Ah, right. I used tc-build to build clang, clang-tools-extra. I will remove 'CLANG_ENABLE_STATIC_ANALYZER': 'OFF', and rebuild clang-tools-extra. Thanks. -- Best Regards Masahiro Yamada
