> On Aug 6, 2020, at 11:08 PM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
>
> * changhuaixin <changhuaixin@xxxxxxxxxxxxxxxxx> wrote:
>
>> Hi, Ingo
>>
>> Another way to write SHT_PROGBITS is using elf_create_section to write orc_lookup table headers, when orc_unwind_ip table and orc_unwind table are written. Is this a better solution?
>>
>> diff --git a/tools/objtool/orc_gen.c b/tools/objtool/orc_gen.c
>> index 3f98dcfbc177..860d4dcec8e6 100644
>> --- a/tools/objtool/orc_gen.c
>> +++ b/tools/objtool/orc_gen.c
>> @@ -183,6 +183,10 @@ int create_orc_sections(struct objtool_file *file)
>> u_sec = elf_create_section(file->elf, ".orc_unwind",
>> sizeof(struct orc_entry), idx);
>>
>> + /* make flags of section orc_lookup right */
>> + if (!elf_create_section(file->elf, ".orc_lookup", sizeof(int), 0))
>> + return -1;
>> +
>> /* populate sections */
>> idx = 0;
>> for_each_sec(file, sec) {
>
> Looks much nicer IMO.
>
> Mind turning this into a proper patch that does it plus reverts the
> hack?
>
A new patchset is sent.
Thanks,
huaixin
> Thanks,
>
> Ingo
