Em Tue, 30 Jun 2020 12:36:27 +0900
Masahiro Yamada <masahiroy@xxxxxxxxxx> escreveu:
> On Mon, Jun 29, 2020 at 6:35 PM Mauro Carvalho Chehab
> <mchehab+huawei@xxxxxxxxxx> wrote:
> >
> > Instead of just changing the helper window to show a
> > dependency, also navigate to it at the config and menu
> > widgets.
> >
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
> > ---
>
>
> I noticed a regression.
>
> Visit "Networking support",
> and click "select: BPF"
> from the window at the bottom.
>
> Nothing happens except the following error message
> in the console:
>
> Clicked menu is invalid: ^BPF$
>
>
> If I apply only 1-4 in this series,
> this works fine.
Hmm... perhaps this is related to symbol visibility. If the clicked
link is not visible, it won't be able to present the Kconfig option.
I guess we can implement a mixed approach here: update just the
configInfo data if it can't find the clicked item as a menu, like
the enclosed patch.
I'll send an updated version with this hybrid approach.
Thanks,
Mauro
diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
index f49fbac91995..fd721c6c4c94 100644
--- a/scripts/kconfig/qconf.cc
+++ b/scripts/kconfig/qconf.cc
@@ -1263,10 +1263,13 @@ void ConfigInfoView::clicked(const QUrl &url)
break;
}
- if (!m)
- qInfo() << "Clicked menu is invalid:" << data;
- else
+ if (!m) {
+ /* Symbol is not visible as a menu */
+ symbolInfo();
+ emit showDebugChanged(true);
+ } else {
emit menuSelected(m);
+ }
free(result);
delete data;
