On Sat, Jun 27, 2020 at 04:04:33AM +0900, Masahiro Yamada wrote: > On Tue, Jun 23, 2020 at 2:37 PM Kees Cook <keescook@xxxxxxxxxxxx> wrote: > > > > On Tue, Jun 23, 2020 at 11:33:53AM +0900, Masahiro Yamada wrote: > > > Is it OK to not patch syscall_x32.c ? > > > > Good question. Peter? (It seems all the syscall_*.c files are just a > > table, not code -- why do they need any instrumentation changes?) I'd still like to know the answer to this one... > Is it useful when we know > DISABLE_STACKPROTECTOR = -fno-stack-protector ? I'm fine with that. My point was the using _REMOVE isn't going to work for some compiler builds. > I'd rather want to apply this patch > https://patchwork.kernel.org/patch/11628493/ > and hard-code -fno-stack-protector where necessary. That's fine. I will send a separate fix for arch/x86/entry/Makefile. > cc-flags-y comes after KBUILD_CFLAGS > so that -fno-stack-protector can negate -fstack-protector(-strong) Okay, good. -- Kees Cook
