On Wed, Jun 24, 2020 at 04:09:20PM +0300, Alexander Popov wrote: > On 24.06.2020 15:53, Luis Chamberlain wrote: > > On Wed, Jun 24, 2020 at 03:33:30PM +0300, Alexander Popov wrote: > >> Add 'verbose' plugin parameter for stackleak gcc plugin. > >> It can be used for printing additional info about the kernel code > >> instrumentation. > >> > >> For using it add the following to scripts/Makefile.gcc-plugins: > >> gcc-plugin-cflags-$(CONFIG_GCC_PLUGIN_STACKLEAK) \ > >> += -fplugin-arg-stackleak_plugin-verbose > > > > Would be nice if we instead could pass an argument to make which lets > > us enable this. > > This feature is useful only for debugging stackleak gcc plugin. > > The cflag that enables it is similar to -fplugin-arg-structleak_plugin-verbose, > which is used for debugging the structleak plugin. > > This debugging feature clutters the kernel build output, I don't think that many > people will use it. So IMO creating a separate argument for make is not really > needed. Yup, agreed. The precedent for plugin verbosity is via CONFIGs. They're not really general purpose enough to justify a "make" argument. -- Kees Cook
