Hi, On Tue, Jun 3, 2020 at 9:33 AM Jonas Zeiger <jonas.zeiger@xxxxxxxxxxxx> wrote: > > Many applications check for available kernel features via: > > - /proc/modules (loaded modules, present if CONFIG_MODULES=y) > - $(MODLIB)/modules.builtin (builtin modules) > > They fail to detect features if the kernel was built with > CONFIG_MODULES=n > and modules.builtin isn't installed. > > Therefore, add the target "_builtin_inst_" and make "install" and > "modules_install" depend on it. > > Tests results: > > - make install: kernel image is copied as before, modules.builtin > copied > - make modules_install: (CONFIG_MODULES=n) nothing is copied, exit 1 > > Signed-off-by: Jonas Zeiger <jonas.zeiger@xxxxxxxxxxxx> > --- > Makefile | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-) Note that this change broke builds in the Chrome OS build system because we require modules to be installed to a certain path and we weren't passing "INSTALL_MOD_PATH" when we called "make install". We can certainly fix our build system (I have a patch at https://crrev.com/c/2237511 for it), but I do wonder if others will hit the same issue. Others might not have such a nice sandboxing system so they might unknowingly try to install files to the build computer's modules directory instead of their target. -Doug
