On Fri, May 15, 2020 at 6:40 PM Denis Efremov <efremov@xxxxxxxxx> wrote: > > It seems that I missed a couple of tar commands in the patch: > scripts/Makefile.package > scripts/package/buildtar > > On 5/15/20 5:20 AM, Masahiro Yamada wrote: > > On Thu, May 14, 2020 at 10:14 PM Denis Efremov <efremov@xxxxxxxxx> wrote: > >> > > > > commit 5054e88a7934d5ff5ec14231c8b8676161bb45fa > > Author: Paul Eggert <eggert@xxxxxxxxxxx> > > Date: Mon Mar 16 14:25:17 2015 -0700 > > > > gzip: make the GZIP env var obsolescent > > Other implementations can depend on this. > pigz still parses GZIP env var: > https://github.com/madler/pigz/blob/master/pigz.c#L4346 > > > > > Some possible options I came up with: > > > > > > [1] Use KGZIP for now, but BZIP2, XZ, etc. for the others. > > > > (Then, rename KGZIP to GZIP when the time comes) > > > > > > [2] Do not take this patch > > > > The whole build process is parallelized > > by 'make -j $(nproc)'. > > > > If you are still eager to use pigz instead gzip, > > use a symbolic link or a wrapper shell script. > > > > $ ln -s /usr/bin/pigz /$HOME/bin/gzip > > $ PATH="$HOME/bin:$PATH" > > > > [3] GZIP at frontend, KGZIP or _GZIP internally? Something like: > > $ cat Makefile > GZIP=gzip > override KGZIP=$(GZIP) # optional overrdide. Used to force GZIP value > # in case: make KGZIP=test > > unexport GZIP The command line option is really strong, so you cannot negate it by 'unexport GZIP'. override GZIP := does not work either in sub-make. > export KGZIP > > default: > @env | grep GZIP > > $ make GZIP=test > KGZIP=test > > Thanks, > Denis -- Best Regards Masahiro Yamada
