Re: [RFC PATCH 1/2] Kconfig: Introduce "uses" keyword

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2020-04-21 at 09:58 -0400, Nicolas Pitre wrote:
> On Tue, 21 Apr 2020, Saeed Mahameed wrote:
> 
> > I wonder how many of those 8889 cases wanted a weak dependency but
> > couldn't figure out how to do it ? 
> > 
> > Users of depends on FOO || !FOO
> > 
> > $ git ls-files | grep Kconfig | xargs grep -E \
> >   "depends\s+on\s+([A-Za-z0-9_]+)\s*\|\|\s*(\!\s*\1|\1\s*=\s*n)" \
> >  | wc -l
> > 
> > 156
> > 
> > a new keyword is required :) .. 
> > 
> > 
> > > In another mail I suggested
> > > 
> > > 	optionally depends on FOO
> > > 
> > > might be a better alternative than "uses".
> > > 
> > > 
> > 
> > how about just:
> >       optional FOO
> > 
> > It is clear and easy to document .. 
> 
> I don't dispute your argument for having a new keyword. But the most 
> difficult part as Arnd said is to find it. You cannot pretend that 

kconfig-language.rst  ?

> "optional FOO" is clear when it actually imposes a restriction when 
> FOO=m. Try to justify to people why they cannot select y because of
> this 
> "optional" thing.
> 

Then let's use "uses" it is more assertive. Documentation will cover
any vague anything about it .. 

> 
> Nicolas




[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux