On Fri, Apr 17, 2020 at 05:01:18PM +0300, Jani Nikula wrote: > On Fri, 17 Apr 2020, Jason Gunthorpe <jgg@xxxxxxxx> wrote: > > On Fri, Apr 17, 2020 at 09:23:59AM +0300, Jani Nikula wrote: > > > >> Which means that would have to split up to two. Not ideal, but > >> doable. > > > > Why is this not ideal? > > > > I think the one per line is easier to maintain (eg for merge > > conflicts) and easier to read than a giant && expression. > > > > I would not complicate things further by extending the boolean > > language.. > > Fair enough. I only found one instance where the patch at hand does not > cut it: > > drivers/hwmon/Kconfig: depends on !OF || IIO=n || IIO Ideally this constraint would be expressed as: optionally depends on OF && IIO And if the expression is n then IIO is not prevented from being y. Ie the code is just doing: #if defined(CONFIG_OF) && IS_ENABLED(CONFIG_IIO) Jason
