On Fri, Apr 17, 2020 at 3:12 AM Saeed Mahameed <saeedm@xxxxxxxxxxxx> wrote:
> @@ -7,10 +7,10 @@ config MLX5_CORE
> tristate "Mellanox 5th generation network adapters (ConnectX series) core driver"
> depends on PCI
> select NET_DEVLINK
> - imply PTP_1588_CLOCK
> - imply VXLAN
> - imply MLXFW
> - imply PCI_HYPERV_INTERFACE
> + uses PTP_1588_CLOCK
> + uses VXLAN
> + uses MLXFW
> + uses PCI_HYPERV_INTERFACE
I have confirmed in the meantime that changing the PCI_HYPERV_INTERFACE
dependency is indeed required, in addition to PTP_1588_CLOCK and VXLAN
that the randconfig tests found earlier:
x86_64-linux-ld: drivers/net/ethernet/mellanox/mlx5/core/main.o: in
function `mlx5_unload':
main.c:(.text+0x325): undefined reference to `mlx5_hv_vhca_cleanup'
I also checked that there is no link failure with MLX5_CORE=y and MLXFW=m,
but only because of an IS_REACHABLE() check in mlxfw/mlxfw.h.
I suppose that should be changed back to IS_ENABLED() now along with
the Kconfig check.
Arnd
