On Mon, Apr 6, 2020 at 8:36 PM Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> wrote: > > On Mon, Apr 06, 2020 at 01:30:52AM +0900, Masahiro Yamada wrote: > > As far as I understood, prom_meminit() in arch/mips/fw/arc/memory.c > > is overridden by the one in arch/mips/sgi-ip32/ip32-memory.c if > > CONFIG_SGI_IP32 is enabled. > > > > The use of EXPORT_SYMBOL in static libraries potentially causes a > > problem for the llvm linker [1]. So, I want to forcibly link lib-y > > objects to vmlinux when CONFIG_MODULES=y. > > > > As a groundwork, we must fix multiple definitions that have previously > > been hidden by lib-y. > > > > The prom_cleanup() in this file is already marked as __weak (because > > it is overridden by the one in arch/mips/sgi-ip22/ip22-mc.c). > > I think it should be OK to do the same for these two. > > > > [1]: https://github.com/ClangBuiltLinux/linux/issues/515 > > > > Reported-by: kbuild test robot <lkp@xxxxxxxxx> > > Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx> > > --- > > > > If MIPS maintainers ack this patch, > > I want to inser it before the following patch: > > > Acked-By: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> > > Thomas. Applied to linux-kbuild with Thomas' Ack. Thanks. > > -- > Crap can work. Given enough thrust pigs will fly, but it's not necessarily a > good idea. [ RFC1925, 2.3 ] > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@xxxxxxxxxxxxxxxx. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20200406110333.GA6266%40alpha.franken.de. -- Best Regards Masahiro Yamada
