On Sun, Mar 29, 2020 at 9:57 PM Reinhard Karcher <reinhard.karcher@xxxxxxx> wrote: > > Am Sonntag, 29. März 2020, 14:01 schrieb Masahiro Yamada: > > > > > By making a contribution to this project, I certify that: > > > The contribution was created in whole or in part by me and I have the > > > right to submit it under the open source license indicated in the file. > > > > Please drop this. > > > > Signed-off-by implies this. > > No need to explain this in an individual patch. > > Droped in attached new version. > > > > +if [ -n "$BUILD_DEBUG" ] ; then > > > > This file does not define BUILD_DEBUG. > > So, this conditional is always false, isn't it? > > > > It should be: > > > > if is_enabled CONFIG_DEBUG_INFO; then > > > > The definition of BUILD_DEBUG is copied from builddeb too. > See attached patch. No. I want you to directly use if is_enabled CONFIG_DEBUG_INFO; then ... fi I guess builddeb used BUILD_DEBUG to avoid running grep twice. It does not apply to mkdebian. -- Best Regards Masahiro Yamada
