> On Mar 26, 2020, at 8:40 AM, Petr Malat <oss@xxxxxxxxx> wrote: > > Hi Nick, > I finally got some time to review your patch, here are my comments: > > On Wed, Mar 25, 2020 at 12:58:42PM -0700, Nick Terrell wrote: >> * Don't export symbols if ZSTD_PREBOOT is defined. > I'm not sure if this is needed. When I worked on my patch, I have found that > all exporting and modinfo macros generate symbols in modinfo and discard.ksym > sections, which are then dropped by the vmlinux linker script, thus one > will get the same binary independently if he puts this change in or not. > > I'm not sure if this is intentional as there is also __DISABLE_EXPORTS define, > which should be used by a decompressor (according to comments in export.h). This is not my area of expertise, I’m a zstd developer not a kernel developer. For that reason I wanted to pick the safe route of disabling the exports explicitly, since that is what the other decompressors do, so I know it works. If you’re confident that it isn’t necessary, I can drop the modification. But, I do prefer this approach, because there is no magic involved. I can see what is happening clearly just by looking at the decompress_unzstd.c code. Thanks for the review, Nick
