On Fri, Mar 20, 2020 at 12:48:20AM +0900, Masahiro Yamada wrote: > Hi Thomas, > > On Thu, Mar 12, 2020 at 5:40 PM Thomas Bogendoerfer > <tsbogend@xxxxxxxxxxxxxxxx> wrote: > > > > On Thu, Mar 12, 2020 at 03:12:28PM +0900, Masahiro Yamada wrote: > > > I got the following report from 0-day bot. > > > Please advise me how to fix it. > > > > > > > > > I am not sure how multi-platform works in MIPS. > > > > > > The cavium-octeon platform has its own implementation > > > of various functions. > > > > > > So, vmlinux links different library routines > > > depending on whether CONFIG_CAVIUM_OCTEON_SOC, correct? > > > > for cavium memcpy is directly linked in via octeon-memcpy.o, while for > > every other platform it's coming from lib/lib.a(memcpy.o). > > > > What have you changed, that this doesn't work anymore ? > > > > Thomas. > > > I want to change all objects from lib-y > to be linked to vmlinux (exactly like obj-y ) > if CONFIG_MODULES is enabled. ic > So, annotating __weak is a good solution > (thanks Nick!). > > If I send a patch, is it acceptable? sure. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
