Hi Michael,
On Mon, Feb 10, 2020 at 2:15 PM Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
>
> Hi Masahiro,
>
> I noticed that "install" seems to be no longer PHONY, or at least if I
> have a file/directory called install then the build doesn't run.
>
> eg:
> $ touch install
> $ make install
> make: 'install' is up to date.
> $ rm install
> $ make install
> LDS arch/powerpc/boot/zImage.lds
> WRAP arch/powerpc/boot/zImage.pseries
> WRAP arch/powerpc/boot/zImage.epapr
I think the reason is
'install' is not specified as a phony target.
You can add 'PHONY += install' to fix it.
PHONY += install # please add this!
install:
$(Q)$(MAKE) $(build)=$(boot) install
Please do so in both arch/powerpc/Makefile and
arch/powerpc/boot/Makefile.
> In the past the presence of an install file/directory didn't have any
> affect.
>
> It seems this changed in:
> d79424137a73 ("kbuild: do not update config when running install targets")
>
> Was that expected?
>
> cheers
I do not think commit is related.
Prior to this commit, I still see the same issue.
$ git checkout d7942413^
$ touch install
$ make -s ARCH=powerpc allnoconfig
$ make ARCH=powerpc install
make: 'install' is up to date.
--
Best Regards
Masahiro Yamada
