On Saturday 08 Feb 2020 at 06:05:02 (+0100), Masahiro Yamada wrote: > On Fri, Feb 7, 2020 at 7:08 PM Quentin Perret <qperret@xxxxxxxxxx> wrote: > > diff --git a/scripts/adjust_autoksyms.sh b/scripts/adjust_autoksyms.sh > > index a904bf1f5e67..58335eee4b38 100755 > > --- a/scripts/adjust_autoksyms.sh > > +++ b/scripts/adjust_autoksyms.sh > > @@ -38,6 +38,10 @@ esac > > # We need access to CONFIG_ symbols > > . include/config/auto.conf > > > > +# The symbol whitelist, relative to the source tree > > +eval ksym_wl="${CONFIG_UNUSED_KSYMS_WHITELIST:-/dev/null}" > > What is this 'eval' needed for? > > This worked for me without it. Right, it is there to expand the path in cases where the user sets the option to "~/my_whitelist" for instance. That could most certainly use a comment, though. Thanks, Quentin