On Mon, Feb 3, 2020 at 12:26 PM Justin Capella <justincapella@xxxxxxxxx> wrote: > > unsigned char maybe? I understand printable chars unlikely to cause > any trouble and probably a non issue, but the domain is different for > char, and while I don't know of supported implementations where sizeof > char isn't a byte, I think it's a possibility and perhaps why u8 was > in use? As I said in the commit description, this only contains ASCII, which is 7-bit code. We do not care the signed-ness of char. kallsyms_names[] has been u8 since the following old commit: commit e10392112d315c45f054c22c862e3a7ae27d17d4 Author: Paulo Marques <pmarques@xxxxxxxxxxxx> Date: Mon Oct 18 17:59:03 2004 -0700 [PATCH] kallsyms data size reduction / lookup speedup Probably, this is just coding mistake. -- Best Regards Masahiro Yamada