On Sun, 2 Feb 2020 14:09:22 +0900
Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
> kallsyms_token_table[] only contains ASCII characters. It should be
> char instead of u8.
Indeed.
Reviewed-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
Thank you,
>
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> ---
>
> kernel/kallsyms.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/kallsyms.c b/kernel/kallsyms.c
> index 136ce049c4ad..53f84f685841 100644
> --- a/kernel/kallsyms.c
> +++ b/kernel/kallsyms.c
> @@ -44,7 +44,7 @@ __attribute__((weak, section(".rodata")));
> extern const unsigned long kallsyms_relative_base
> __attribute__((weak, section(".rodata")));
>
> -extern const u8 kallsyms_token_table[] __weak;
> +extern const char kallsyms_token_table[] __weak;
> extern const u16 kallsyms_token_index[] __weak;
>
> extern const unsigned int kallsyms_markers[] __weak;
> @@ -58,7 +58,8 @@ static unsigned int kallsyms_expand_symbol(unsigned int off,
> char *result, size_t maxlen)
> {
> int len, skipped_first = 0;
> - const u8 *tptr, *data;
> + const char *tptr;
> + const u8 *data;
>
> /* Get the compressed symbol length from the first symbol byte. */
> data = &kallsyms_names[off];
> --
> 2.17.1
>
--
Masami Hiramatsu <mhiramat@xxxxxxxxxx>
