On Mon, Dec 9, 2019 at 5:19 PM Thomas Hebb <tommyhebb@xxxxxxxxx> wrote: > > This series fixes several issues with help text generated by Kconfig, > mainly affecting symbols that are defined in multiple places. Although > results of these patches are somewhat visible for the symbols in Linux, > what prompted me to write the series was working on U-Boot, which also > uses Kconfig and makes very heavy use of multiple definitions (e.g. for > overriding defaults). I have provided Linux examples where I could find > them, but the example for the biggest patch (the first one) is taken > from U-Boot because it was more illustrative than anything I could find > in Linux. Nice patch set. Thanks for sending it to kbuild ML first (then you or somebody else will backport it to U-Boot) BTW, talking about U-Boot, it abuses the multi-definition feature too much. This always causes broken dependency when U-Boot migrate CONFIG options to Kconfig. :-/ For my arm64 boards, I used CONFIG_POSITION_INDEPENDENT instead of coping with CONFIG_SYS_TEXT_BASE mess... > Thomas Hebb (4): > kconfig: list all definitions of a symbol in help text > kconfig: don't crash on NULL expressions in expr_eq() > kconfig: distinguish between dependencies and visibility in help text > kconfig: fix nesting of symbol help text > > scripts/kconfig/expr.c | 8 +++-- > scripts/kconfig/expr.h | 1 + > scripts/kconfig/menu.c | 75 ++++++++++++++++++++++++------------------ > 3 files changed, 50 insertions(+), 34 deletions(-) > > -- > 2.24.0 > -- Best Regards Masahiro Yamada
