> -----Original Message----- > From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > Sent: Friday, October 25, 2019 12:30 PM > To: Keller, Jacob E <jacob.e.keller@xxxxxxxxx>; Masahiro Yamada > <yamada.masahiro@xxxxxxxxxxxxx> > Cc: intel-wired-lan@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-kbuild > <linux-kbuild@xxxxxxxxxxxxxxx> > Subject: Re: [PATCH] namespace: fix namespace.pl script to support relative > paths > > On 10/25/19 10:45 AM, Keller, Jacob E wrote: > > > >> -----Original Message----- > >> From: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> > >> Sent: Wednesday, October 23, 2019 6:22 PM > >> To: Keller, Jacob E <jacob.e.keller@xxxxxxxxx> > >> Cc: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>; intel-wired-lan@xxxxxxxxxxxxxxxx; > >> linux-kernel@xxxxxxxxxxxxxxx; linux-kbuild <linux-kbuild@xxxxxxxxxxxxxxx> > >> Subject: Re: [PATCH] namespace: fix namespace.pl script to support relative > >> paths > >> > >> If you want to detect missing 'static', > >> have you tried 'sparse'? > >> > > > > We've used that as well. > > > > To be fair, I agree that it covers similar functionality as other tools. I haven't > looked directly at namespace.pl output in a while, and the fix here is multiple > years old that took a long time to get picked up. > > > > If it's agreed that the tool has no value, and especially if it results in false > indications of a problem, then maybe removing it to prevent someone from mis- > reading its output makes sense? > > If there is a satisfactory alternative, I expect that namespace.pl is old, > unmaintained, and unneeded, and should go away. > > -- > ~Randy Given Yamada's comments and my experience, modpost and sparse are both good at detecting the issues that namespace.pl handles. I am not sure if there's any other output that would be valuable from namespace.pl, but if not.. I don't see a reason to keep it compared to the other tools. Thanks, Jake
