On Thu, Oct 10, 2019 at 12:47:31PM +0200, Michal Simek wrote: > On 08. 10. 19 17:46, Christoph Hellwig wrote: > > On Tue, Oct 08, 2019 at 12:34:47PM +0200, Michal Simek wrote: > >> index e5c9170a07fc..83417105c00a 100644 > >> --- a/arch/microblaze/include/asm/Kbuild > >> +++ b/arch/microblaze/include/asm/Kbuild > >> @@ -25,6 +25,7 @@ generic-y += local64.h > >> generic-y += mcs_spinlock.h > >> generic-y += mm-arch-hooks.h > >> generic-y += mmiowb.h > >> +generic-y += msi.h > > > > Please just mark it as mandatory-y in the asm-generic makefile > > instead of requiring a sniplet for every architecture. > > > > But is it really mandatory for all architectures? What the mandatory-y keyword means is that every architecture that doesn't provide its own header gets the default one, which seems applicable here. Maybe the keyword is a bit misnamed and should be default-y or something like that.. But in this case I think we have a clear case of x86 vs the rest, which is unlikely to change in a major way.
